[Puppi] Hadronic tau recovery with protection for fromPV==2 charged particles #44050

nurfikri89 · 2024-02-21T19:42:29Z

PR description:

(Making this PR on behalf of @abenecke)

It was spotted by the ParticleNet team that the efficiency to identify hadronic tau candidates for PUPPI jets at low pT is significantly lower than for CHS jets (https://indico.cern.ch/event/1300663/#2-particlenet-ak4-ak8-tagger-r). The main reason for this is that PUPPI treats particles with fromPV1&2 different than CHS. It was found that PUPPI rejects one prong hadronic taus that most of the time has fromPV==2 and pT < 20 GeV (pT > 20 GeV are protected by PUPPI already). This PR is supposed to recover the loss of hadronic tau candidates by keeping charged particles with pT > 4 GeV and fromPV==2 while maintaining the jet energy resolution, eff and purity for jets. A comparison of different options was done in this presentation: https://indico.cern.ch/event/1364503/#5-puppi-tau-tune

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_0_X

…be false by default in the module.

cmsbuild · 2024-02-21T19:42:51Z

cms-bot internal usage

cmsbuild · 2024-02-21T19:49:30Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44050/38988

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44050/38988/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44050/38988/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-02-21T20:07:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44050/38990

This PR adds an extra 16KB to repository

cmsbuild · 2024-02-21T20:08:01Z

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

CommonTools/PileupAlgos (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@rappoccio, @hatakeyamak, @missirol, @ahinzmann, @gkasieczka, @jdolen this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

hqucms · 2024-02-23T12:25:58Z

please test

cmsbuild · 2024-02-23T18:31:07Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9c0ec/37637/summary.html
COMMIT: dd92bc9
CMSSW: CMSSW_14_1_X_2024-02-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44050/37637/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 6 lines from the logs
Reco comparison results: 4114 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3245365
DQMHistoTests: Total failures: 6959
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3238384
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

vlimant · 2024-02-27T10:18:41Z

assign xpog

cmsbuild · 2024-02-27T10:19:03Z

New categories assigned: xpog

@vlimant,@hqucms you have been requested to review this Pull request/Issue and eventually sign? Thanks

mandrenguyen · 2024-02-29T17:26:41Z

Based on the PR description, I understand why changes are observed for Puppi jets, but were you expecting changes to the vanilla slimmedJets (presumably CHS?), e.g:
here

nurfikri89 · 2024-02-29T20:01:02Z

@mandrenguyen the plot says its slimmedJetsAK8 so its the AK8 Puppi jets, which we expect some changes.

hqucms · 2024-03-01T10:13:27Z

@nurfikri89 Has it been checked what are impacts of this change on the existing AK4 and AK8 jet taggers?

nurfikri89 · 2024-03-02T11:53:22Z

@hqucms this is in the process by @abenecke

vlimant · 2024-03-27T19:03:49Z

+1

cmsbuild · 2024-03-27T19:04:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-03-27T20:06:46Z

please test

need to refresh tests.

cmsbuild · 2024-03-27T23:03:57Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9c0ec/38469/summary.html
COMMIT: dd92bc9
CMSSW: CMSSW_14_1_X_2024-03-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44050/38469/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 6 lines to the logs
Reco comparison results: 3944 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297857
DQMHistoTests: Total failures: 5488
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3292349
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

antoniovilela · 2024-03-28T12:22:55Z

@nurfikri89 Has it been checked what are impacts of this change on the existing AK4 and AK8 jet taggers?

@nurfikri89
You mentioned this was being checked. Could you summarize the conclusions?
Thanks.

rappoccio · 2024-03-28T13:16:56Z

+reconstruction Only puppi jets are affected, although I found a bit confusing that slimmedJetsAK8 is done with PUPPI, but slimmedJets (i.e., R=0.4) are not. I wonder if we shouldn't always just state the UE subtraction algo for clarity, e.g., slimmedJetsCHS. At least if we're planning to continue to support two algos.

This was a historical accident.

rappoccio · 2024-03-28T13:17:21Z

Apologies, I accidentally clicked the wrong button.

rappoccio · 2024-04-01T17:28:33Z

+1

mandrenguyen · 2024-04-02T07:43:38Z

type tau, jetmet

…pre0_puppi_tauTune_fromPV2Recovery [Puppi] Backport of #44050 (Hadronic tau recovery with protection for fromPV==2 charged particles) to 14_0_X

nurfikri89 added 2 commits February 21, 2024 10:09

Add fromPV2Recovery option to recover tau reco efficiency. Set it to …

62fdc6a

…be false by default in the module.

Switch on UseFromPV2Recovery flag and set pt min value to be 4.

c41d3a7

cmsbuild added this to the CMSSW_14_1_X milestone Feb 21, 2024

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 21, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 21, 2024

Apply code-format patch

dd92bc9

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 21, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 21, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 23, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 23, 2024

cmsbuild added the xpog-pending label Feb 27, 2024

cmsbuild added the reconstruction-approved label Mar 1, 2024

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Mar 27, 2024

cmsbuild added tests-started and removed tests-approved labels Mar 27, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 27, 2024

nurfikri89 mentioned this pull request Mar 27, 2024

[Puppi] Backport of #44050 (Hadronic tau recovery with protection for fromPV==2 charged particles) to 14_0_X #44566

Merged

rappoccio closed this Mar 28, 2024

rappoccio reopened this Mar 28, 2024

cmsbuild added orp-approved and removed orp-pending labels Apr 1, 2024

cmsbuild merged commit 1b3f760 into cms-sw:master Apr 1, 2024
11 checks passed

cmsbuild added tau jetmet labels Apr 2, 2024

nurfikri89 deleted the from1410pre0_puppi_tauTune_fromPV2Recovery branch June 17, 2024 21:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Puppi] Hadronic tau recovery with protection for fromPV==2 charged particles #44050

[Puppi] Hadronic tau recovery with protection for fromPV==2 charged particles #44050

nurfikri89 commented Feb 21, 2024

cmsbuild commented Feb 21, 2024 •

edited

Loading

cmsbuild commented Feb 21, 2024

cmsbuild commented Feb 21, 2024

cmsbuild commented Feb 21, 2024

hqucms commented Feb 23, 2024

cmsbuild commented Feb 23, 2024

vlimant commented Feb 27, 2024

cmsbuild commented Feb 27, 2024

mandrenguyen commented Feb 29, 2024

nurfikri89 commented Feb 29, 2024

hqucms commented Mar 1, 2024

nurfikri89 commented Mar 2, 2024 •

edited

Loading

vlimant commented Mar 27, 2024

cmsbuild commented Mar 27, 2024

antoniovilela commented Mar 27, 2024

cmsbuild commented Mar 27, 2024

antoniovilela commented Mar 28, 2024

rappoccio commented Mar 28, 2024

rappoccio commented Mar 28, 2024

rappoccio commented Apr 1, 2024

mandrenguyen commented Apr 2, 2024

[Puppi] Hadronic tau recovery with protection for fromPV==2 charged particles #44050

[Puppi] Hadronic tau recovery with protection for fromPV==2 charged particles #44050

Conversation

nurfikri89 commented Feb 21, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Feb 21, 2024 • edited Loading

cmsbuild commented Feb 21, 2024

cmsbuild commented Feb 21, 2024

cmsbuild commented Feb 21, 2024

hqucms commented Feb 23, 2024

cmsbuild commented Feb 23, 2024

Comparison Summary

vlimant commented Feb 27, 2024

cmsbuild commented Feb 27, 2024

mandrenguyen commented Feb 29, 2024

nurfikri89 commented Feb 29, 2024

hqucms commented Mar 1, 2024

nurfikri89 commented Mar 2, 2024 • edited Loading

vlimant commented Mar 27, 2024

cmsbuild commented Mar 27, 2024

antoniovilela commented Mar 27, 2024

cmsbuild commented Mar 27, 2024

Comparison Summary

antoniovilela commented Mar 28, 2024

rappoccio commented Mar 28, 2024

rappoccio commented Mar 28, 2024

rappoccio commented Apr 1, 2024

mandrenguyen commented Apr 2, 2024

cmsbuild commented Feb 21, 2024 •

edited

Loading

nurfikri89 commented Mar 2, 2024 •

edited

Loading